Skip to content

Allow customization of MAG L2 frames#2881

Merged
maxinelasp merged 3 commits intoIMAP-Science-Operations-Center:devfrom
alastairtree:feat/allow-mag-l2-frames-to-be-customised
Apr 2, 2026
Merged

Allow customization of MAG L2 frames#2881
maxinelasp merged 3 commits intoIMAP-Science-Operations-Center:devfrom
alastairtree:feat/allow-mag-l2-frames-to-be-customised

Conversation

@alastairtree
Copy link
Copy Markdown
Collaborator

Change Summary

Overview

Adds option to customise which frames are generated when calling mag l2 programatically. Used (externally) by MAG team to generate l2 files without needing all CDF files

Testing

I have updated the unite tests to cover this new use case.
The main API has not actually changed as this is just a new param with defaults that match the existing behaviou so should have zero consequences other than making it more flexible

- in mag_l2 function and update tests accordingly
- used (externally) by MAG team to generate l2 files without needing all files
@alastairtree alastairtree marked this pull request as ready for review March 30, 2026 11:45
@alastairtree
Copy link
Copy Markdown
Collaborator Author

Paging @maxinelasp - please could you take a look at this, a small change to MAG L2 to enable us to generate frames programmatically without having to generate all of them. We (intend) to call this code in our internal pipeline over at https://github.com/ImperialCollegeLondon/imap-pipeline-core/blob/feat/set-quality-and-nan/src/mag_toolkit/calibration/CalibrationApplicator.py#L207

@alastairtree
Copy link
Copy Markdown
Collaborator Author

Thanks @maxinelasp. What is the cadence of your releases & when can i expect to see this change on pypy? No pressure, just want to know what to expect.

@maxinelasp
Copy link
Copy Markdown
Contributor

@alastairtree We usually do a few a month - if you would like this out ASAP, I can cut a release this week

@alastairtree
Copy link
Copy Markdown
Collaborator Author

alastairtree commented Apr 1, 2026

Next routine release is fine thanks. I cant merge it so over to you to release it please and thank you!

@maxinelasp maxinelasp merged commit cbff0a3 into IMAP-Science-Operations-Center:dev Apr 2, 2026
14 checks passed
@laspsandoval
Copy link
Copy Markdown
Contributor

@alastairtree we just released imap_processing.

@alastairtree alastairtree deleted the feat/allow-mag-l2-frames-to-be-customised branch April 10, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants